Skip to content

OcdFileExport: Harmonize warning messages #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

OcdFileExport: Harmonize warning messages #2245

wants to merge 1 commit into from

Conversation

@dl3sdo
Copy link
Member

@dl3sdo dl3sdo commented Jun 21, 2024

Warning messages were not consistent regarding whether

  • the symbol name is quoted (text symbols were unquoted)
  • they end with a dot
  • details are separated by a comma or a colon

@dl3sdo
OcdFileExport: Harmonize warning messages
ce90584 
Warning messages were not consistent regarding whether
- the symbol name is quoted (text symbols were unquoted)
- they end with a dot
- details are separated by a comma or a colon
@dl3sdo
Copy link
Member Author

dl3sdo commented Jun 21, 2024

Regarding consistency:
.ocd import has a different style, e.g.
In line symbol 862.0 'Treppe': Skipped secondary point symbol.

@dg0yt
Copy link
Member

dg0yt commented Jun 22, 2024

  • This affects translations. Without manual edits, existing translations are no longer used, immediately.
  • OcdFileImport has overloads addSymbolWarning for (OCD) symbol types which use per-type variants of "In area symbol %1 '%2': %3" to decouple the repeated text from the individual details. Maybe this is a pattern to adopt and adopt in other places.

@dl3sdo dl3sdo marked this pull request as draft June 22, 2024 11:16
@dg0yt dg0yt added this to the v0.9.6+1 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.9.6+1

Development

Successfully merging this pull request may close these issues.

2 participants

@dl3sdo @dg0yt